feat: allow passing a certification payload #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
pass_certification
branch
from
bef309f
to
bb18ee1
Compare
zephyring
reviewed
May 3, 2023
| @@ -73,6 +73,7 @@ def sync_datasets( # pylint: disable=too-many-locals, too-many-branches, too-ma | |||
| database: Any, | |||
| disallow_edits: bool, | |||
| external_url_prefix: str, | |||
| certification=None, | |||
There was a problem hiding this comment.
Ah, I forgot! Sorry, will fix!
zephyring
reviewed
May 3, 2023
| database={"id": 1, "sqlalchemy_uri": "postgresql://user@host/examples_dev"}, | ||
| disallow_edits=False, | ||
| external_url_prefix="", | ||
| certification={"details": "This dataset is synced from dbt Cloud"}, |
There was a problem hiding this comment.
do we already have another test case when cert is None
zephyring
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a certification payload when syncing datasets from dbt.