Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding config option for filtering models #204

Merged
merged 4 commits into from
May 11, 2023
Merged

Conversation

hughhhh
Copy link
Contributor

@hughhhh hughhhh commented May 5, 2023

Users now will be able to filter Model.config values when running the cli

$ dbt run --select config.materialized:view

# w/ config
{{ config(
  materialized = 'view',
  unique_key = ['column_a', 'column_b'],
  grants = {'select': ['reporter', 'analysts']},
  transient = true
) }}

@hughhhh
Copy link
Contributor Author

hughhhh commented May 5, 2023

resolves #187

@@ -386,6 +386,12 @@ def test_filter_models() -> None:
"unique_id": "model.three",
"depends_on": ["source.zero"],
"children": ["model.two"],
"config": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing because you need to add config to the other models, even if it's an empty dict.

@hughhhh hughhhh requested a review from betodealmeida May 9, 2023 19:05
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@betodealmeida betodealmeida merged commit 4ebf741 into main May 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants