fix: Escaping Jinja logical statements from assets #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Escaping Jinja logical statements from assets
fixing structure
Update README.rst
Fixing pylint issues
betodealmeida
approved these changes
May 19, 2023
Comment on lines
191
to
194
| if disable_jinja_templating: | ||
| config = load_yaml(path_name) | ||
| else: | ||
| config = render_yaml(path_name, env) |
There was a problem hiding this comment.
Small nit:
config = load_yaml(path_name) if disable_jinja_templating else render_yaml(path_name, env)There was a problem hiding this comment.
thanks! changed as suggested
Comment on lines
198
to
201
| if disable_jinja_templating: | ||
| overrides = load_yaml(overrides_path) | ||
| else: | ||
| overrides = render_yaml(overrides_path, env) |
There was a problem hiding this comment.
changed this one as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements escaping for Jinja logical statements (#188), and also adds two new flags:
--disable-jinja-templating: This flag was added to thesync nativecommand, so that the CLI doesn't render any Jinja templating from the assets. This is useful in case the assets contain Jinja and were exported via the UI (and therefore the syntax wasn't escaped).--disable-jinja-escaping: This flag was added to theexport-assetscommand, so that the CLI doesn't escape Jinja syntax from the YAML files. This is useful in case the assets contain Jinja and would be imported through the UI.Also, these two flags can be used in case the escaping/rendering logic is incorrectly escaping/rendering incorrect values (like JSON curly brackets, etc).