Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export-rls): Support Preset and older Superset versions #227

Merged
merged 4 commits into from
Jul 18, 2023

Conversation

Vitor-Avila
Copy link
Contributor

This PR improves the export-roles command, so that it supports Preset (and most recent Superset versions) since this was migrated to react and APIs. It also support older Superset instances in which RLS don't have a name and description.

This addresses #223.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@Vitor-Avila Vitor-Avila merged commit 0143ac1 into main Jul 18, 2023
4 checks passed
@Vitor-Avila Vitor-Avila deleted the rls-fix branch July 18, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants