Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbt): Load profiles with Jinja #280

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

mtrentz
Copy link
Contributor

@mtrentz mtrentz commented Apr 10, 2024

fixes #279

Uses load_profiles function so that it reads variables defined as JINJA on profiles.yml

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

@Vitor-Avila
Copy link
Contributor

Hi @mtrentz,

Thank you so much for the contribution, and also for signing our CLA 🙌 ! I think it would be interesting to add a test case specifically for this scenario (to prevent regression/etc). Would you be up for it? I know the load_profiles method already existed and was covered, but I was thinking about a test that simulates the dbt sync command while having the profiles file with Jinja2.

I'm more than happy to contribute the test as well -- let me know what works best for you.

Thanks!

@mtrentz
Copy link
Contributor Author

mtrentz commented Apr 18, 2024

Hey @Vitor-Avila, added a simple test to this. It would fail if not for the original change. Tell me if this seems enough :)

Copy link
Contributor

@Vitor-Avila Vitor-Avila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much!!!

@Vitor-Avila Vitor-Avila merged commit d2dbeb8 into preset-io:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbt-core-sync] Not loading variables defined as Jinja in profiles.yml
3 participants