Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pin sqlglot to <23 #283

Merged
merged 1 commit into from
Apr 16, 2024
Merged

chore: Pin sqlglot to <23 #283

merged 1 commit into from
Apr 16, 2024

Conversation

Vitor-Avila
Copy link
Contributor

This PR sets an upper bound to the sqlglot version -- the CLI doesn't work properly when using a version >=23.0.0.
Fixes #282

Also bumped pip-tools as I was facing errors to run pip-compile.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set it to >=23, and update the call to walk? We're going to have to do that eventually.

@Vitor-Avila
Copy link
Contributor Author

Vitor-Avila commented Apr 16, 2024

@betodealmeida that's true and I'm happy to take a look on that as part of a bigger effort to review our dependencies (we might need to also bump Jinja2 to be compatible with metricflow and other dbt dependencies).

Just trying to get the installs unblocked while we can tackle this more strategically.

@Vitor-Avila Vitor-Avila merged commit 258b69b into main Apr 16, 2024
5 checks passed
@Vitor-Avila Vitor-Avila deleted the sqlglot-bound branch April 16, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBT metricflow error on standalone superset version
2 participants