chore(dbt): Instruct users of missing dependency when creating a Snowflake virtual dataset #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
May 1, 2024
Comment on lines
+214
to
+221
| if dialect == "snowflake": | ||
| raise CLIError( | ||
| ( | ||
| "Missing required package. " | ||
| 'Please run ``pip install "preset-cli[snowflake]"`` to install it.' | ||
| ), | ||
| 1, | ||
| ) from exc |
There was a problem hiding this comment.
In the future this could be something like:
if dialect in {"snowflake", "redshift", "bigquery"}:
raise CLIError(
(
"Missing required package. "
f'Please run ``pip install "preset-cli[{dialect}]"`` to install it.'
),
1,
) from exc
betodealmeida
approved these changes
May 2, 2024
| @@ -198,6 +201,31 @@ def build_snowflake_sqlalchemy_params(target: Dict[str, Any]) -> Dict[str, Any]: | |||
| return parameters | |||
|
|
|||
|
|
|||
| def create_sqlalchemy_engine(url: URL): | |||
There was a problem hiding this comment.
Suggested change
| def create_sqlalchemy_engine(url: URL): | |
| def create_sqlalchemy_engine(url: URL) -> Engine: |
With:
from sqlalchemy.engine import EngineAlso, maybe we should rename this to create_engine_with_check or something more explicit? To make it clear how it's different from create_engine.
There was a problem hiding this comment.
great catch! and great idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbt is compatible with warehouses that support creating multiple DBs in the same instance (such as Snowflake). Since the
databaseis specified in the DB connection string in Superset, when a model is created in a different database, the CLI creates it as a virtual dataset (usingselect * from db_name.schema.table).SQLAlchemy's
create_engine()method might require the DB-specific driver to work. This PR adds proper instructions to users when facing this issue. It currently only coverssnowflake, but covering more engines should be straightforward.