chore(dbt sync): Deprecate using the dbt_project file to trigger a dbt sync #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
Jun 3, 2024
| @@ -160,17 +157,18 @@ def dbt_core( # pylint: disable=too-many-arguments, too-many-branches, too-many | |||
| "The managed externally feature was only introduced in Superset v1.5." | |||
| "Make sure you are running a compatible version." | |||
| ) | |||
| log_warning(warn_message, UserWarning) | |||
| _logger.debug(warn_message) | |||
There was a problem hiding this comment.
Changed it to debug as it might make more sense (given it might not be a concern).
betodealmeida
approved these changes
Jun 3, 2024
Comment on lines
+167
to
+169
| "Passing the dbt_project.yml file is deprecated and " | ||
| "will be removed in a future version. " | ||
| "Please pass the manifest.json file instead." |
There was a problem hiding this comment.
Hoping to have a single supported method soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to trigger the dbt Core sync specifying the path to either the
manifest.jsonfile or to thedbt_project.ymlfile. The former would currently display aDeprecationWarning.dbt deprecated the
target-pathas a config in thedbt_project.yml(which is used when triggering the command with this file) so this PR is moving the deprecated warning to when syncing with the path todbt_project.ymlfile specified. For simplicity, I would recommend dropping support entirely in a future release and relying solely in themanifest.jsonfile.This PR also moves away from using
warnings.warn()as it breaks logging (not a concern when using thepreset-clias a standalone CLI, but could be impactful when using it as a dependency and relying on its methods).