fix(dbt Core): Support syncing metrics without a MetricFlow dialect #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitor-Avila
commented
Jun 20, 2024
| @@ -111,7 +111,7 @@ | |||
| ) | |||
| @raise_cli_errors | |||
| @click.pass_context | |||
| def dbt_core( # pylint: disable=too-many-arguments, too-many-branches, too-many-locals ,too-many-statements | |||
| def dbt_core( # pylint: disable=too-many-arguments, too-many-branches, too-many-locals ,too-many-statements # noqa: C901 | |||
There was a problem hiding this comment.
There's some logic getting deprecated in this method soon that should allow us to remove # noqa: C901. I could also plan a bigger refactor to break this down into smaller methods (but I think it deserves its own PR).
eschutho
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricFlow is not compatible with all DB engines supported by dbt Core yet. Currently, triggering a dbt Core sync in this scenario would raise an error. This PR gracefully handles this case and still processes legacy metrics.
Fixes #288.