chore: improve export by ID #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,18 +77,29 @@ def export_assets( # pylint: disable=too-many-locals, too-many-arguments | |||
| "chart": {int(id_) for id_ in chart_ids}, | |||
| "dashboard": {int(id_) for id_ in dashboard_ids}, | |||
| } | |||
| ids_requested = database_ids or dataset_ids or chart_ids or dashboard_ids | |||
There was a problem hiding this comment.
NIT(optional): could be a tiny bit more clear is
were_any_ids_requested = any([database_ids, dataset_ids, chart_ids, dashboard_ids])There was a problem hiding this comment.
Ah, I like it! Let me fix.
mistercrunch
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes to the
superset exportcommand. First, if IDs are specified for any resource type, then all assets are exported by ID. The command:superset-cli export --database-ids=1,2Will export only databases with ID 1 and 2, and no datasets, charts, nor dashboards will be exported. Before: this would export databases with ID 1 and 2, but also all datasets, charts, and dashboards.
Second, when an ID is specified, related assets are also exported. The command:
superset-cli export --dashboard-ids=1 --asset-type=dashboardWill export dashboard with ID 1, but also all its associated charts, datasets, and databases. Before: this would export only the dashboard with ID 1, but not export associated resources.
IDs for multiple resource types can be specified:
superset-cli export --dashboard-ids=1 --chart-ids=42Will export dashboard with ID 1 and related assets, as well as chart with ID 42 and related assets.