Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(embedded): Control Filter bar visibility/state via the embedded SDK #15

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

Vitor-Avila
Copy link
Contributor

Replicating changes made to the Superset SDK here. Original PR: apache/superset#21070

I believe I should also bump the version as @jfrag1 did in this PR -- going to mark this as WIP for now and bump it to 0.1.8 after his changes are merged.

@Vitor-Avila Vitor-Avila marked this pull request as draft August 21, 2023 16:03
@jfrag1
Copy link
Contributor

jfrag1 commented Aug 21, 2023

@Vitor-Avila My PR is merged

@Vitor-Avila Vitor-Avila marked this pull request as ready for review August 21, 2023 17:01
@Vitor-Avila
Copy link
Contributor Author

thanks @jfrag1 just bumped the version here as well based on your PR.

Copy link
Contributor

@jfrag1 jfrag1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vitor-Avila Vitor-Avila merged commit 68feb16 into main Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants