Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter parameters from DB API (#21248) #266

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov-commenter
Copy link

Codecov Report

Merging #266 (3f94ff1) into 2022.33.3 (8fe4601) will decrease coverage by 14.84%.
The diff coverage is 60.71%.

@@              Coverage Diff               @@
##           2022.33.3     #266       +/-   ##
==============================================
- Coverage      66.27%   51.43%   -14.85%     
==============================================
  Files           1770     1770               
  Lines          67535    67616       +81     
  Branches        7183     7183               
==============================================
- Hits           44761    34775     -9986     
- Misses         20939    31006    +10067     
  Partials        1835     1835               
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto ?
python 50.81% <65.04%> (-30.68%) ⬇️
sqlite ?
unit 50.81% <65.04%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aseModal/DatabaseConnectionForm/EncryptedField.tsx 10.00% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 31.52% <0.00%> (ø)
superset/databases/api.py 52.09% <ø> (-43.41%) ⬇️
superset/databases/commands/update.py 25.86% <0.00%> (-65.37%) ⬇️
superset/databases/commands/validate.py 29.50% <0.00%> (-44.63%) ⬇️
superset/models/helpers.py 34.69% <0.00%> (-4.63%) ⬇️
superset/databases/dao.py 69.76% <40.00%> (-30.24%) ⬇️
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 83.33% <50.00%> (ø)
superset/db_engine_specs/bigquery.py 53.40% <50.00%> (-33.27%) ⬇️
superset/db_engine_specs/gsheets.py 75.39% <69.23%> (+0.39%) ⬆️
... and 324 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sadpandajoe sadpandajoe merged commit d78e17c into preset-io:2022.33.3 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants