Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Tempfile paths in shell commands #1544

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Ignore Tempfile paths in shell commands #1544

merged 1 commit into from
Jan 18, 2021

Conversation

presidentbeef
Copy link
Owner

Ignore uses of Tempfile#path in shell commands.

Also adds support for Tempfiles like:

Tempfile.open('...') do |file|
  # Brakeman knows `file` is a Tempfile
end

@presidentbeef presidentbeef force-pushed the temp_file_path_in_command_injection branch from a3e3e59 to 980de69 Compare January 18, 2021 03:44
@presidentbeef presidentbeef merged commit 3fccde7 into main Jan 18, 2021
@presidentbeef presidentbeef deleted the temp_file_path_in_command_injection branch January 18, 2021 03:48
This was referenced Mar 17, 2021
Closed
Closed
Repository owner locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@presidentbeef