New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation on ignore actions? #949

Closed
janwerkhoven opened this Issue Oct 17, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@janwerkhoven

janwerkhoven commented Oct 17, 2016

When running brakeman -I at some point we get this:

Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?)

Where can we find documentation on these cryptic actions??

Action: (i, n, k, u, a, s, q, ?)
@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 17, 2016

Owner

Hi Jan,

Sorry for the confusion. I suppose that's what I get for copying an interface from git 😕

If you enter ? it provides the definitions:

Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
Owner

presidentbeef commented Oct 17, 2016

Hi Jan,

Sorry for the confusion. I suppose that's what I get for copying an interface from git 😕

If you enter ? it provides the definitions:

Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
@janwerkhoven

This comment has been minimized.

Show comment
Hide comment
@janwerkhoven

janwerkhoven Oct 17, 2016

Cool, thanks for the tip 😄
Love your work by the way, useful gem

janwerkhoven commented Oct 17, 2016

Cool, thanks for the tip 😄
Love your work by the way, useful gem

@janwerkhoven

This comment has been minimized.

Show comment
Hide comment
@janwerkhoven

janwerkhoven Oct 17, 2016

Interesting, so when I enter ? I do get to see the bottom bit.

--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?)

So it is there, but just not showing above the fold? I'm using iTerm 2.

Using arrows, spacebar and scroll don't help showing the bit below the fold.

janwerkhoven commented Oct 17, 2016

Interesting, so when I enter ? I do get to see the bottom bit.

--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?)

So it is there, but just not showing above the fold? I'm using iTerm 2.

Using arrows, spacebar and scroll don't help showing the bit below the fold.

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 17, 2016

Owner

It only shows when you enter ?, not automatically for every warning.

I have opened #950 to show the help output once prior to going through each warning.

Owner

presidentbeef commented Oct 17, 2016

It only shows when you enter ?, not automatically for every warning.

I have opened #950 to show the help output once prior to going through each warning.

@presidentbeef

This comment has been minimized.

Show comment
Hide comment
@presidentbeef

presidentbeef Oct 17, 2016

Owner

I think this has been clarified and addressed.

Owner

presidentbeef commented Oct 17, 2016

I think this has been clarified and addressed.

Repository owner locked and limited conversation to collaborators Mar 10, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.