No documentation on ignore actions? #949

Closed
janwerkhoven opened this Issue Oct 17, 2016 · 5 comments

Projects

None yet

2 participants

@janwerkhoven
janwerkhoven commented Oct 17, 2016 edited

When running brakeman -I at some point we get this:

Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?)

Where can we find documentation on these cryptic actions??

Action: (i, n, k, u, a, s, q, ?)
@presidentbeef
Owner

Hi Jan,

Sorry for the confusion. I suppose that's what I get for copying an interface from git ๐Ÿ˜•

If you enter ? it provides the definitions:

Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
@janwerkhoven
janwerkhoven commented Oct 17, 2016 edited

Cool, thanks for the tip ๐Ÿ˜„
Love your work by the way, useful gem

@janwerkhoven
janwerkhoven commented Oct 17, 2016 edited

Interesting, so when I enter ? I do get to see the bottom bit.

--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?) ?
i - Add warning to ignore list
n - Add warning to ignore list and add note
s - Skip this warning (will remain ignored or shown)
u - Remove this warning from ignore list
a - Ignore this warning and all remaining warnings
k - Skip this warning and all remaining warnings
q - Quit, do not update ignored warnings
? - Display this help
--------------------
Confidence: Weak
Category: Redirect
Message: Possible unprotected redirect
Code: ...
File: ...
Line: 21
Action: (i, n, k, u, a, s, q, ?)

So it is there, but just not showing above the fold? I'm using iTerm 2.

Using arrows, spacebar and scroll don't help showing the bit below the fold.

@presidentbeef
Owner
presidentbeef commented Oct 17, 2016 edited

It only shows when you enter ?, not automatically for every warning.

I have opened #950 to show the help output once prior to going through each warning.

@presidentbeef
Owner
presidentbeef commented Oct 17, 2016 edited

I think this has been clarified and addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment