Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the appearance of the default front page catalog #365

Closed
SteelWagstaff opened this issue Oct 26, 2022 · 7 comments
Closed

Improve the appearance of the default front page catalog #365

SteelWagstaff opened this issue Oct 26, 2022 · 7 comments
Assignees

Comments

@SteelWagstaff
Copy link
Member

SteelWagstaff commented Oct 26, 2022

As a network manager, I want the front page catalog block to better reflect the improved/attractive new catalog. Currently, if I turn on the front page catalog:
Screenshot from 2022-10-26 12-21-33

the home page displays 3 colored blocks with book titles and about this book links and a carousel to display more books (scroll left/right buttons) with a link beneath to take the user to the 'complete catalog':
Screenshot from 2022-10-26 12-23-18

We should make space for 4 featured books, should replace the color blocks with book covers and display the titles just beneath (as links to the book homepages). We can remove the carousel feature. The catalog link should point to whichever page uses the catalog template on their network. We need to handle cases where a network has multiple catalog pages (perhaps they can choose from a dropdown in the customizer for where the link goes?)

Network managers should be able to designate up to four books from their catalog as featured books in the customizer using a 4 drop down selectors that let them choose from any book in the network catalog as a featured book: 'Featured book 1' 'Featured book 2', etc.

@richard015ar
Copy link
Contributor

richard015ar commented Oct 26, 2022

An acceptable solution for multiple catalogues is to allow networks to have only one page designated as a catalog template page.

@arzola arzola self-assigned this Nov 1, 2022
@SteelWagstaff SteelWagstaff assigned fdalcin and unassigned arzola Nov 7, 2022
@fdalcin
Copy link
Contributor

fdalcin commented Nov 8, 2022

Reviewed and left a comment related to a minor issue I've detected while reviewing

@SteelWagstaff
Copy link
Member Author

SteelWagstaff commented Nov 8, 2022

I don't see any of the book covers after choosing 4 books as 'featured' on integrations:
Screenshot from 2022-11-08 13-45-52

See https://integrations.pressbooks.network/

@SteelWagstaff SteelWagstaff removed their assignment Nov 8, 2022
@arzola
Copy link
Contributor

arzola commented Nov 8, 2022

I'll review it :whatshappeningJJ:

@SteelWagstaff
Copy link
Member Author

Images are now appearing (I had to clear my browser cache). I would like us to make a couple of small adjustments to default size of the cover blocks.

A few suggestions to make:

  • reduce margin-top on .featured_book__title to match the margin-bottom (i.e. 1rem)
  • increase height of the .featured_book and .featured_book__cover elements so it has a better height/width ratio. Maybe try 30rem for featured book and 85% for faetured_book__cover?

Rationale: Our default book cover is 800px (tall) x 600px (wide), with a height to width ratio of 4:3 (or 1.33). Our current block has a default size of 318.91px x 286px (1.15). This is too small, especially because many books have cover ratios that fall between 1.4 - 1.6. There's probably a better, more scientific way to do this, but I think I want the default ratio for the cover image div to be somewhere in the range of 1.33 - 1.5.

@arzola
Copy link
Contributor

arzola commented Nov 9, 2022

What do you think to set by default an aspect ratio of 3/4 instead of doing rem, In my opinion looks good

#373

@arzola arzola assigned SteelWagstaff and unassigned arzola Nov 9, 2022
@SteelWagstaff
Copy link
Member Author

Works as expected. Aspect ratio is now 4:3 with images centered so that excess content is cut off on top/bottom or left/right of overflow. We should consider improving instructions for cover images, if we expect/require them to have these 4:3 dimensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants