Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aspect ratio #373

Merged
merged 4 commits into from
Nov 15, 2022
Merged

fix: aspect ratio #373

merged 4 commits into from
Nov 15, 2022

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Nov 9, 2022

This PR sets the featured book card aspect ratio to be 3/4 to have a better cover visualization

image

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this quite gets us where we want to go. Here's an example where I have four covers of different sizes (800x1200px, 1039x1087, 800x800, and 1000x1500). Notice how content is cropped at bottom for images that have 1.5x ratio and at right for images with 1x ratio. Also notice how height of featured blocks differ when title text spans two lines.

Screenshot from 2022-11-14 12-16-28

Let me think a bit more on how we want this to function before proposing changes.

@arzola
Copy link
Contributor Author

arzola commented Nov 15, 2022

@SteelWagstaff I sent an update that I think it could work, the height of the titles are even and the background cover position is now centered for squared images (1:1) I mean I think there is no a perfect crop trying to fit squared images with portrait and landscape ratios but I think using 3:4 with a centered approach for the other ratios looks good enough

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteelWagstaff SteelWagstaff merged commit 79648d3 into dev Nov 15, 2022
@SteelWagstaff SteelWagstaff deleted the featured-cards-improvements branch November 15, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants