Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use wp-cli i18n command instead of pb-cli #335

Merged
merged 6 commits into from
Jun 6, 2022

Conversation

greatislander
Copy link
Contributor

Partial resolution to https://github.com/pressbooks/private/issues/910. In addition to replacing the wp pb make-pot command with wp i18n make-pot, this PR also replaces the update-translations.yml workflow's use of gettext with the wp i18n make-mo command, which does the same thing.

I've commented out the step which autocommits changes. Instead, when these workflows run if they result in any changed files, they will open a PR. Devs can merge if it looks good. In future, you may wish to switch back to autocommit.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #335 (90bff6e) into dev (2a0ff78) will not change coverage.
The diff coverage is n/a.

❗ Current head 90bff6e differs from pull request most recent head 2a61733. Consider uploading reports for the commit 2a61733 to get more accurate results

@@          Coverage Diff          @@
##             dev    #335   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines        590     590           
=====================================
  Misses       590     590           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0ff78...2a61733. Read the comment docs.

Copy link
Member

@SteelWagstaff SteelWagstaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SteelWagstaff SteelWagstaff merged commit ffbf3f1 into pressbooks:dev Jun 6, 2022
@greatislander greatislander deleted the feat/wp-i18n branch August 5, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants