Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom frontend page #375

Merged
merged 1 commit into from
Nov 10, 2022
Merged

feat: custom frontend page #375

merged 1 commit into from
Nov 10, 2022

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Nov 9, 2022 •
edited by SteelWagstaff
Loading

This PR address #364

How to test.

  1. Go to the customizer
  2. Find a new option called Frontpage Settings
  3. Change the frontpage to use the one that you want

Expected behaviour: the front page looks good when you select home, any other page that has been created, and/or a page with the catalog template applied.

@richard015ar richard015ar self-requested a review November 10, 2022 16:01
richard015ar
richard015ar approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@richard015ar richard015ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tested with multiple custom pages including the new catalog.
It works as expected.

@richard015ar richard015ar merged commit 3f1e0e0 into dev Nov 10, 2022
@richard015ar richard015ar deleted the custom-frontpage branch November 10, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard015ar richard015ar richard015ar approved these changes

Assignees

@richard015ar richard015ar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arzola @richard015ar