Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added php 7.3-7.4 compatibility checker #976

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Feb 16, 2022

This PR adds an extra check to ensure our codebase doesn't have any deprecated or non compatible function within our supported PHP versions

https://github.com/pressbooks/private/issues/815

@private-packagist
Copy link

private-packagist bot commented Feb 16, 2022

composer.lock

Package changes

Package Operation From To Changes
phpcompatibility/php-compatibility add - 9.3.5 view code
squizlabs/php_codesniffer add - 3.5.8 view code

Dev Package changes

Package Operation From To Changes
phpcompatibility/php-compatibility remove 9.3.5 - -
squizlabs/php_codesniffer remove 3.5.8 - -

Settings · Docs · Powered by Private Packagist

@private-packagist
Copy link

The composer.lock diff comment has been updated to reflect new changes in this PR.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #976 (6cf19da) into dev (c7706d5) will not change coverage.
The diff coverage is n/a.

❗ Current head 6cf19da differs from pull request most recent head 03c4797. Consider uploading reports for the commit 03c4797 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #976   +/-   ##
=======================================
  Coverage   47.20%   47.20%           
=======================================
  Files           4        4           
  Lines         500      500           
=======================================
  Hits          236      236           
  Misses        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7706d5...03c4797. Read the comment docs.

@SteelWagstaff SteelWagstaff merged commit 3f10e78 into dev Feb 17, 2022
@SteelWagstaff SteelWagstaff deleted the php74-check branch February 17, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants