Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use featured image when provided #62

Merged
merged 1 commit into from
Sep 26, 2022
Merged

feat: use featured image when provided #62

merged 1 commit into from
Sep 26, 2022

Conversation

fdalcin
Copy link
Contributor

@fdalcin fdalcin commented Sep 26, 2022 •
edited
Loading

Issue #13, pressbooks/pressbooks-aldine#189

This PR renders the post's featured image when available. It falls back to the default if no featured image is provided.

How to test

  1. With this plugin active, update the catalog page to add a featured image to the post
  2. View the catalog page and make sure the featured image is used as the background header image.

arzola
arzola approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@arzola arzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome LGTM, simple and efficient

@arzola arzola merged commit 799e7f3 into development Sep 26, 2022
@arzola arzola deleted the feature/render-featured-image branch September 26, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arzola arzola arzola approved these changes

@SteelWagstaff SteelWagstaff Awaiting requested review from SteelWagstaff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fdalcin @arzola