Clone media metadata (Fixes #1280) #1337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix is different than what #1280 recommends. Reasons:
wp/v2/media
exposes all media in the library. No concept of public/private per image._wp_attachment_metadata
can be fake or incompatible. It's more accurate to side load the file and have WordPress recreate this kind of info.Fix keeps the current approach of looking for media actually being used in book, then copies PB metadata when found.