Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pb_cover_large thumbnail image for API #2212

Closed
arzola opened this issue Jun 11, 2021 · 1 comment · Fixed by #2214
Closed

Use pb_cover_large thumbnail image for API #2212

arzola opened this issue Jun 11, 2021 · 1 comment · Fixed by #2214
Assignees

Comments

@arzola
Copy link
Contributor

arzola commented Jun 11, 2021

This PR #2174 added large thumbnail URLs to the API. We want to change

$cover_path = wp_get_attachment_image_url( $cover_id, 'large', false );
to pb_cover_large

@arzola
Copy link
Contributor Author

arzola commented Jun 11, 2021

@SteelWagstaff medium_large is returning a bigger thumbnail than large hahaha, maybe we could use pb_cover_large size because it seems we are overriding wp image sizes here https://github.com/pressbooks/pressbooks/blob/2fa944f49a20d531e3e6dcdb4e90635ac7c505f3/inc/image/namespace.php pb_cover_large is the one that is being used on the theme to show the book cover. I think is good enough it looks good on my retina display

@SteelWagstaff SteelWagstaff linked a pull request Jun 14, 2021 that will close this issue
@SteelWagstaff SteelWagstaff changed the title Use medium_large thumbnail image for API Use pb_cover_large thumbnail image for API Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants