Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix book information #329

Closed
greatislander opened this issue Jan 4, 2016 · 3 comments
Closed

Fix book information #329

greatislander opened this issue Jan 4, 2016 · 3 comments
Assignees

Comments

@greatislander
Copy link
Contributor

Right now our book information is stored as post meta on a custom post type. This adds an unnecessary layer of abstraction to accessing the book meta—first we need to get the post ID of custom metadata post which contains the book info, then we can get the book info. It would probably be better to migrate all book information to the wp_options table for each book.

@greatislander greatislander self-assigned this Jan 4, 2016
@greatislander greatislander added this to the 3.5 milestone Jan 4, 2016
@greatislander greatislander modified the milestones: v4.0, v3.5.0 Apr 27, 2016
@greatislander
Copy link
Contributor Author

This needs to wait. Implementing using the WP Settings API is going to be a headache and I'd rather not rely on any other third-party field management plugins going forward. Best to track the progress of https://github.com/sc0ttkclark/wordpress-fields-api and re-implement once it gets merged into core.

@colomet
Copy link
Contributor

colomet commented May 2, 2017

Once you decided what to do, let me know and we will use the same approach in our plugin.

https://github.com/Books4Languages/pressbooks-metadata/issues/41

@greatislander greatislander removed this from the 4.0 milestone Jun 29, 2017
@greatislander
Copy link
Contributor Author

Closing this, for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants