Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In new themes, footnote block needs variables for top-margin & border #748

Closed
4 tasks done
hughmcguire opened this issue May 16, 2017 · 2 comments
Closed
4 tasks done
Assignees

Comments

@hughmcguire
Copy link
Member

Prerequisites

Check the boxes below by changing them from [ ] to [x].

Description

In new theme structure there is no mechanism to control footnote block top-margin & border.

Need to add in ~styles/components/specials/_footnotes.scss the following:

@page {
  @footnotes {
    margin-top: $footnote-block-margin-top;
    border-top: $footnote-block-border-top;
 }
}

and then in ~styles/variables/specials.scss the following:

// footnotes
$footnote-block-margin-top: .5em;
$footnote-block-border-top: 0;

and test.

@hughmcguire
Copy link
Member Author

note: i should do this but pressed for time & don't want to mess anything up.

@greatislander
Copy link
Contributor

Closed in favour of pressbooks/pressbooks-book#2

@greatislander greatislander removed this from the 4.0 milestone Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants