Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title attribute on logo and site title + add aria-label attribute #1719

Closed
ghost opened this issue Mar 25, 2019 · 3 comments · Fixed by #1721
Closed

Remove title attribute on logo and site title + add aria-label attribute #1719

ghost opened this issue Mar 25, 2019 · 3 comments · Fixed by #1721

Comments

@ghost
Copy link

ghost commented Mar 25, 2019

Question asked here : https://secure.helpscout.net/conversation/809522240/216714?folderId=607547

Why ? this doesn't add anything. We usually know that the site title or logo refers to home.
Websites usually don't display any title attribute on logo.

For accessibility, aria-label should be enough ? @eri-trabiccolo do you know anything about this ?

@eri-trabiccolo I assign this to you. Not urgent. When you'll have the time.

@eri-trabiccolo
Copy link
Collaborator

Yeah the title attribute is going to die. :D
Looking at:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute

Basically I think (for what I understand) the aria-label should not be added when displaying the site-title only, we should use the aria-labelledby (the link labelled by the site-title element) in that case.

@ghost
Copy link
Author

ghost commented Mar 25, 2019

OK thanks.
Let's go for those arias then.

@eri-trabiccolo
Copy link
Collaborator

So I'm going to use the aria-label for the link that wraps the logo, while no aria attributes are necessary for the site-title link, as the link text already says everything.
To be honest I'm not totally sure it is needed for the logo link, as the logo image has an alt...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant