Add is_array() check on _normalizeValueCraft2 to avoid possible type errors #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, odd one, not sure why an existing field would be a string? Will get the array check added in the next release. Thanks. |
|
Sorry for the delay on responding to this. In my case, this was because I had switched from a different plugin to this one. This would also be the case if you were to switch from a plain text field to the LinkIt field, bit of an edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I started rolling this plugin out on a Craft site today to replace a few existing link plugins and ran into an issue where the
_normalizeValueCraft2function would attempt to grab the type of existing content which was a string, this would cause 500 errors in both the control panel and on the site itself.I've just added a quick is_array() check to that function and that seems to have done the trick!