Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO TRANSACTION annotation is case sensitive #765

Closed
visortelle opened this issue May 9, 2024 · 7 comments
Closed

NO TRANSACTION annotation is case sensitive #765

visortelle opened this issue May 9, 2024 · 7 comments

Comments

@visortelle
Copy link

According to the documentation, annotations are case-insensitive: https://pressly.github.io/goose/reference/annotations/

Screenshot 2024-05-09 at 10 18 12 AM

However, I wasn't able to get rid of the CREATE INDEX CONCURRENTLY cannot run inside a transaction block error without setting the NO TRANSACTION annotation in upper-case.

@mfridman
Copy link
Collaborator

mfridman commented May 9, 2024

Which version of goose are you using?

The case sensitive annotations were added in v3.19.1.

@visortelle
Copy link
Author

github.com/pressly/goose v2.7.0+incompatible // indirec
github.com/pressly/goose v2.7.0+incompatible h1:PWejVEv07LCerQEzMMeAtjuyCKbyprZ/LBa6K5P0OCQ=
github.com/pressly/goose v2.7.0+incompatible/go.mod h1:m+QHWCqxR3k8D9l7qfzuC/djtlfzxr34mozWDYEu1z8

@visortelle
Copy link
Author

Ah, ok. It's already 3.20.x. Let me update and check.

@visortelle
Copy link
Author

Thanks @mfridman
Confirm, that it works as expected on v3.
Closing.

@mfridman
Copy link
Collaborator

mfridman commented May 9, 2024

It'd be nice if we added the minimum version throughout the docs (which I'm currently working to expand).

But it's a bit of overhead to track, so not sure we'll end up doing it due to maintenance cost.

@mfridman
Copy link
Collaborator

Also, I just noticed you mentioned going from v2.7.0+incompatible to 3.20.x. and it just worked?

We tried really hard to keep backwards compatibility so I'm glad nothing broke for you!

@visortelle
Copy link
Author

@mfridman Don't worry, I use goose in a new project that doesn't have a live database yet.
In v3 the no transaction annotation works in both upper and lower cases, so it's backward compatible.
Thanks for taking care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants