This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
fixing the IN operator syntax and adding ANY, SOME, ALL operators to where clause #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2017 09:28
felipeweb
suggested changes
Aug 23, 2017
postgres/postgres.go
Outdated
|
|
||
| case "ANY", "SOME", "ALL": | ||
| whereKey = append(whereKey, fmt.Sprintf(`%s = %s ($%d)`, key, op, pid)) | ||
| whereValues = append(whereValues, pq.Array(strings.Split(value, ","))) |
There was a problem hiding this comment.
please use our function FormatArray instead pq.Array
postgres/postgres.go
Outdated
| @@ -129,7 +130,7 @@ func chkInvalidIdentifier(identifer ...string) bool { | |||
| // WhereByRequest create interface for queries + where | |||
| func WhereByRequest(r *http.Request, initialPlaceholderID int) (whereSyntax string, values []interface{}, err error) { | |||
| whereKey := []string{} | |||
| whereValues := []string{} | |||
| whereValues := []interface{}{} | |||
There was a problem hiding this comment.
if you use our function FormatArray instead pq.Array this variable don't need to be []interface{} can be []string
|
Sure, I will do that after Monday.
…On Aug 23, 2017 15:07, "Felipe Oliveira" ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Add some docs on operators section in README about these new supported
operators.
Add some tests for these new operators.
i requested some changes in your code.
@tarnowsc <https://github.com/tarnowsc> thank you for the PR 🎉 🎉 🎉
------------------------------
In postgres/postgres.go
<#13 (comment)>:
>
+ switch op {
+ case "IN", "NOT IN":
+ v := strings.Split(value, ",")
+ keyParams := make([]string, len(v))
+ for i := 0; i < len(v); i++ {
+ whereValues = append(whereValues, v[i])
+ keyParams[i] = fmt.Sprintf(`$%d`, pid+i)
+ }
+ pid += len(v)
+ whereKey = append(whereKey, fmt.Sprintf(`%s %s (%s)`, key, op, strings.Join(keyParams, ",")))
+
+ case "ANY", "SOME", "ALL":
+ whereKey = append(whereKey, fmt.Sprintf(`%s = %s ($%d)`, key, op, pid))
+ whereValues = append(whereValues, pq.Array(strings.Split(value, ",")))
please use our function FormatArray instead pq.Array
------------------------------
In postgres/postgres.go
<#13 (comment)>:
> @@ -129,7 +130,7 @@ func chkInvalidIdentifier(identifer ...string) bool {
// WhereByRequest create interface for queries + where
func WhereByRequest(r *http.Request, initialPlaceholderID int) (whereSyntax string, values []interface{}, err error) {
whereKey := []string{}
- whereValues := []string{}
+ whereValues := []interface{}{}
if you use FormatArray instead pq.Array this variable don't need to be
[]interface{} can be []string
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABA1P_14dSINWBbTD8nyMRGi_eVJ5VsQks5sbCQdgaJpZM4O_nQS>
.
|
|
Is this PR still alive? |
avelino
reviewed
Sep 18, 2017
felipeweb
suggested changes
Sep 18, 2017
postgres/postgres.go
Outdated
| whereKey = append(whereKey, fmt.Sprintf(`%s %s`, key, op)) | ||
| case "=", "!=", ">", ">=", "<", "<=": |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I couldn't make $in. operator to work as it was producing malformed sql query.
The problem with pq lib is that the IN clause is not really properly supported and it is better to use arrays with ANY operator. Therefore I've added support for $any. $some. and $all.
The syntax to pass multiple values is as follows:
http://127.0.0.1:8000/DATABASE/SCHEMA/TABLE?id=$any.14,2,5
http://127.0.0.1:8000/DATABASE/SCHEMA/TABLE?string_id=$any.'14','2','5'
Best Regards
Cezary