Skip to content
This repository has been archived by the owner on Jul 29, 2020. It is now read-only.

Fix insertTableNameQuotesRegex to support hyphen in dbname #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarath16933
Copy link

Signed-off-by: Sarath sveedu@akamai.com

Fixes: prest/prest#369

Signed-off-by: Sarath <sveedu@akamai.com>
@sourcelevel-bot
Copy link

Hello, @sarath16933! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Signed-off-by: Sarath <sveedu@akamai.com>
Copy link
Member

@tiaguinho tiaguinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to write test for these regex

@avelino
Copy link
Member

avelino commented Jul 23, 2020

ping @sarath16933

@avelino
Copy link
Member

avelino commented Jul 29, 2020

@sarath16933 we are in the process of centralizing the repository to simplify the contribution and maintainability of pREST.
do you send your contribution to the main repository (this will be archived)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants