Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to prevent multiple configuration loads #131

Merged
merged 7 commits into from Apr 7, 2017
Merged

Refactoring to prevent multiple configuration loads #131

merged 7 commits into from Apr 7, 2017

Conversation

crgimenes
Copy link
Contributor

Prevent multiple configuration loads
Remove unnecessary code
Remove redundant variables

avelino
avelino requested changes Apr 7, 2017
View reviewed changes
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

2017/04/07 16:25:54 could not prepare sql: INSERT INTO prest.public.test6 (prest) VALUES ($1) RETURNING nuveo
 Error: pq: column "prest" of relation "test6" does not exist

@codecov
Copy link

codecov bot commented Apr 7, 2017 •
edited

Codecov Report

Merging #131 into master will decrease coverage by 0.22%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage    89.6%   89.37%   -0.23%     
==========================================
  Files          10       10              
  Lines         827      828       +1     
==========================================
- Hits          741      740       -1     
- Misses         55       56       +1     
- Partials       31       32       +1
Impacted Files Coverage Δ
config/middlewares/middlewares.go 80% <ø> (-1.82%) ⬇️
config/config.go 77.77% <80%> (-4.05%) ⬇️
adapters/postgres/connection/conn.go 77.77% <80%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d062e82...50dcae9. Read the comment docs.

felipeweb
felipeweb approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@felipeweb felipeweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avelino avelino added this to the 0.1.5 milestone Apr 7, 2017
@avelino avelino merged commit 4cc7b84 into master Apr 7, 2017
@avelino avelino deleted the crg-minor-fixes branch April 7, 2017 18:42
@avelino avelino modified the milestones: 0.1.7, 0.1.5 Apr 20, 2017
avelino pushed a commit that referenced this pull request Jul 16, 2020
@crgimenes
Refactoring to prevent multiple configuration loads (#131)
7168199 
* Remove unnecessary code

* Remove unnecessary code

* Remove unnecessary code

* update test to use load instead of InitConf

load function is new private function to load config on init() of
config package

* Remove unnecessary code

* A small refactoring to prevent multiple configuration loads

* remove InitConf
avelino pushed a commit that referenced this pull request Jul 16, 2020
@crgimenes
Refactoring to prevent multiple configuration loads (#131)
39d1b75 
* Remove unnecessary code

* Remove unnecessary code

* Remove unnecessary code

* update test to use load instead of InitConf

load function is new private function to load config on init() of
config package

* Remove unnecessary code

* A small refactoring to prevent multiple configuration loads

* remove InitConf
avelino pushed a commit that referenced this pull request Jul 16, 2020
@crgimenes
Refactoring to prevent multiple configuration loads (#131)
3dd2d28 
* Remove unnecessary code

* Remove unnecessary code

* Remove unnecessary code

* update test to use load instead of InitConf

load function is new private function to load config on init() of
config package

* Remove unnecessary code

* A small refactoring to prevent multiple configuration loads

* remove InitConf
avelino pushed a commit that referenced this pull request Jul 16, 2020
@crgimenes
Refactoring to prevent multiple configuration loads (#131)
089c60e 
* Remove unnecessary code

* Remove unnecessary code

* Remove unnecessary code

* update test to use load instead of InitConf

load function is new private function to load config on init() of
config package

* Remove unnecessary code

* A small refactoring to prevent multiple configuration loads

* remove InitConf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelino avelino avelino approved these changes

@felipeweb felipeweb felipeweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crgimenes @avelino @felipeweb