Improve json return #158
Merged
Improve json return #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 85.32% 85.68% +0.35%
==========================================
Files 11 11
Lines 879 852 -27
==========================================
- Hits 750 730 -20
+ Misses 85 82 -3
+ Partials 44 40 -4
Continue to review full report at Codecov.
|
marioidival
approved these changes
Jun 2, 2017
| @@ -263,50 +263,15 @@ func Query(SQL string, params ...interface{}) (jsonData []byte, err error) { | |||
| return | |||
| } | |||
|
|
|||
| SQL = fmt.Sprintf("SELECT json_agg(s) FROM (%s) s", SQL) | |||
avelino
added a commit
that referenced
this pull request
Jun 6, 2017
* 'master' of github.com:nuveo/prest: Change key with respect to JWT token (#164) Correct readme example Minor refactor (#160) Add array support (#156) Improve json return (#158) remove mock prevent more than load when use pREST as a module (#155) a mock of database connection (#154) implement funcs to help scripts (#152) fix bug in insert json (#150) introduce debug mode (#148)
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Use json_agg instead of assembling the answer and then return the json via Go * remove redundant string * remove ";" from requests * remove statement_timeout test * remove TestMockUsage * update TestGetSchemas * go fmt
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Use json_agg instead of assembling the answer and then return the json via Go * remove redundant string * remove ";" from requests * remove statement_timeout test * remove TestMockUsage * update TestGetSchemas * go fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to issue #157