refactor migrate commands #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove create command and goto command, refactor migration to use transaction to be able roolback when a file with multiple statements fail In case of goto we removed because it do the same of next. Create: we need a command that just create a file? Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
This reverts commit 8733843.
Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
Signed-off-by: Felipe Oliveira <fpo@felipeweb.dev>
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| @@ -1394,3 +1394,18 @@ func (adapter *Postgres) SchemaTablesOrderBy(order string) (orderBy string) { | |||
| } | |||
| return | |||
| } | |||
|
|
|||
| func (adapter *Postgres) ShowTable(schema, table string) adapters.Scanner { | |||
There was a problem hiding this comment.
exported method Postgres.ShowTable should have comment or be unexported
| @@ -350,6 +350,10 @@ func (m *Mock) BatchInsertCopy(dbname, schema, table string, keys []string, valu | |||
| return | |||
| } | |||
|
|
|||
| func (m *Mock) ShowTable(schema, table string) (sc adapters.Scanner) { | |||
There was a problem hiding this comment.
exported method Mock.ShowTable should have comment or be unexported
* set docker registry path fixed: #431 Signed-off-by: Avelino <t@avelino.xxx> * fixed travis PR test Signed-off-by: Avelino <t@avelino.xxx>
Signed-off-by: Avelino <t@avelino.xxx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #386
Remove create command and goto command, refactor migration to use
transaction to be able rollback when a file with multiple statements
fail
In case of goto we removed because it do the same of next.
Create: we need a command that just create a file?
Signed-off-by: Felipe Oliveira fpo@felipeweb.dev