-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sitemap dump directory absolute #225
Comments
I agree with this proposal, default paths should not rely where is the command running from |
You cannot trust i think this parameter must be required to fill in configuration (without default value). And of course it must be absolute. |
This is just a default value, we had to find a way to define it, and you can still change it if you want. This is not easy to guess at that moment, and it will be painful to require that every project configure it even if not using anything exotic. So no, we won't go that way. The |
At the moment, the configured directory where the sitemap is dumped is :
web
for Symfony < 4.0public
for Symfony >= 4.0But this directory is not absolute.
Commands are usually triggered from the project root dir (where the composer.json is stored) so it makes no difference. But if you trigger your command from anywhere else, you may have dumped your sitemap files to an unwanted dir.
Should this bundle use absolute dir for default values ?
%kernel.root_dir%/../web
for Symfony < 4.0%kernel.project_dir%/public
for Symfony >= 4.0The text was updated successfully, but these errors were encountered: