[FIX] Fixed deprecated warnings. Improved max compatible version #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Aug 11, 2022
| try: | ||
| from __builtin__ import basestring | ||
| except ImportError: | ||
| from past.types import basestring |
There was a problem hiding this comment.
Why not past.builtins?
There was a problem hiding this comment.
Because past.builtins imports past.builtins.misc
and past.builtins.misc imports from imp
and imp has deprecated warning
There was a problem hiding this comment.
@pedrobaeza are you ok with the above explanation?
pedrobaeza
reviewed
Aug 11, 2022
|
Please squash both commits into one, or separate correctly each change (deprecated warnings vs max compatible version). |
ventor-dev
force-pushed
the
Fix_deprecate_warnings
branch
from
de61c99
to
4b53bf3
Compare
|
I made one commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the library, depricate warnings regularly appear:
/Users/okuryan/Development/15.0/venv/lib/python3.8/site-packages/future/standard_library/init.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
First one generated by the method install_aliases(). It make sense only on Python 3.xx because it monkey-patches the standard library in Python 2.xx to provide aliases for better Python 3.xx compatibility
Second one generated by past.builtins, becuse it imports past.builtins.misc module that imports imp
Also I suggest setting the lower digit version to 99. This will help to avoid constantly changing this value when a new version of PrestaShop is released