-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding throughput test to benchto #68
Conversation
|
As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto. Original PR: trinodb/benchto#26 Co-authored-by: Paweł Pałucha, Karol Sobczak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@upbram123 Hi Ram, the back ported PR needs to follow the PR/commit message guidelines and include cherry pick PR/commit ids: https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines. Will you please update them? Thank you!
As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto. Original PR: trinodb/benchto#26 Co-authored-by: Paweł Pałucha, Karol Sobczak |
As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto. Original PR: trinodb/benchto#26 Cherry-pick of trinodb/benchto@a26b7f8 Co-authored-by: Paweł Pałucha, Karol Sobczak Adding throughput test to benchto
2d6163c
to
e671639
Compare
int finalThread = thread; | ||
executionCallables.add(() -> { | ||
LOG.info("Running throughput test: {} queries, {} runs", benchmark.getQueries().size(), runs); | ||
int[] queryOrder = PermutationUtils.preparePermutation(benchmark.getQueries().size(), finalThread); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be able to run pre-defined ordered queries.
As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto.
Original PR: trinodb/benchto#26
Cherry-pick of trinodb/benchto@a26b7f8
Co-authored-by: Paweł Pałucha, Karol Sobczak