Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding throughput test to benchto #68

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

upbram123
Copy link
Contributor

@upbram123 upbram123 commented Jul 28, 2022

As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto.

Original PR: trinodb/benchto#26
Cherry-pick of trinodb/benchto@a26b7f8

Co-authored-by: Paweł Pałucha, Karol Sobczak

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 28, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@upbram123
Copy link
Contributor Author

upbram123 commented Aug 1, 2022

As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto.

Original PR: trinodb/benchto#26
Cherry-pick of trinodb/benchto@a26b7f8

Co-authored-by: Paweł Pałucha, Karol Sobczak

Copy link
Contributor

@yingsu00 yingsu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upbram123 Hi Ram, the back ported PR needs to follow the PR/commit message guidelines and include cherry pick PR/commit ids: https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines. Will you please update them? Thank you!

@upbram123
Copy link
Contributor Author

As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto.

Original PR: trinodb/benchto#26
Cherry-pick of trinodb/benchto@a26b7f8

Co-authored-by: Paweł Pałucha, Karol Sobczak

As per TPC-H specification, we have to run power test and throughput test. currently benchto doesn't support throughput test and this PR is for to add that support into benchto.

Original PR: trinodb/benchto#26
Cherry-pick of trinodb/benchto@a26b7f8

Co-authored-by: Paweł Pałucha, Karol Sobczak

Adding throughput test to benchto
@yingsu00 yingsu00 merged commit c299791 into prestodb:master Aug 10, 2022
int finalThread = thread;
executionCallables.add(() -> {
LOG.info("Running throughput test: {} queries, {} runs", benchmark.getQueries().size(), runs);
int[] queryOrder = PermutationUtils.preparePermutation(benchmark.getQueries().size(), finalThread);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be able to run pre-defined ordered queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants