Add missing field to CreateTableAsSelect hashcode/equals

prestodb · Oct 28, 2015 · 16bf58f · 16bf58f
1 parent 1bf2f54
commit 16bf58f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java b/presto-main/src/main/java/com/facebook/presto/sql/analyzer/StatementAnalyzer.java
@@ -500,7 +500,7 @@ protected TupleDescriptor visitCreateTableAsSelect(CreateTableAsSelect node, Ana
         }
         accessControl.checkCanCreateTable(session.getIdentity(), targetTable);
 
-        analysis.setCreateTableAsSelectWithData(node.getWithData());
+        analysis.setCreateTableAsSelectWithData(node.isWithData());
 
         // analyze the query that creates the table
         TupleDescriptor descriptor = process(node.getQuery(), context);

diff --git a/presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateTableAsSelect.java b/presto-parser/src/main/java/com/facebook/presto/sql/tree/CreateTableAsSelect.java
@@ -52,7 +52,7 @@ public Map<String, Expression> getProperties()
         return properties;
     }
 
-    public boolean getWithData()
+    public boolean isWithData()
     {
         return withData;
     }
@@ -66,7 +66,7 @@ public <R, C> R accept(AstVisitor<R, C> visitor, C context)
     @Override
     public int hashCode()
     {
-        return Objects.hash(name, query, properties);
+        return Objects.hash(name, query, properties, withData);
     }
 
     @Override
@@ -81,7 +81,8 @@ public boolean equals(Object obj)
         CreateTableAsSelect o = (CreateTableAsSelect) obj;
         return Objects.equals(name, o.name)
                 && Objects.equals(query, o.query)
-                && Objects.equals(properties, o.properties);
+                && Objects.equals(properties, o.properties)
+                && Objects.equals(withData, o.withData);
     }
 
     @Override