Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing credentials are causing a different exception now #16569

Closed
Airblader opened this issue Aug 5, 2021 · 1 comment
Closed

Missing credentials are causing a different exception now #16569

Airblader opened this issue Aug 5, 2021 · 1 comment

Comments

@Airblader
Copy link

In Apache Flink we are using PrestoS3FileSystem. We recently updated from presto-hive 0.187 to 0.257. This brought in a change of behavior in case credentials were missing. In our testcase, we intentionally provide no credentials and then check that #exists() on a path fails. We specifically asserted on an IOException here.

Somewhere between 0.187 and 0.257, PrestoS3FileSystem#initialize was changed to call createAwsCredentialsProvider. Now if credentials are missing, this already fails and throws an SdkClientException instead.

I'm not sure whether you consider this correct or not, but since presto uses IOException in many places and this has now changed I wanted to report it in case you consider this an unintended change in behavior.

References:

@Airblader
Copy link
Author

Sorry for the noise. My description above is incorrect, and should've read

Somewhere between 0.187 and 0.257, PrestoS3FileSystem was changed to use DefaultAWSCredentialsProviderChain in #createAwsCredentialsProvider rather than throwing an exception in what was then called getAwsCredentialsProvider.

However, even then it was a RuntimeException, not an IOException, so the point is moot for presto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant