Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-23487][FLINK-23635][s3] Update aws and presto-hive #16717

Closed
wants to merge 2 commits into from

Conversation

Airblader
Copy link
Contributor

@Airblader Airblader commented Aug 5, 2021

See #16592 for description of the main PR. This PR is a fixup after it has been reverted.

We previously expected and asserted on an IOException. However, presto-hive now uses the AWSCredentialsProviderChain when building the S3 client, and we instead fail with an SdkClientException.

See

Edit 1: The PR originally passed the CI because this test is not executed for PRs.

Edit 2: Since the original PR has been reverted in the meantime I have re-added that commit to this hotfix PR and updated the description.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: yes

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 5, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3911d13 (Sat Aug 28 13:10:20 UTC 2021)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @Airblader. I'm wondering whether we should wrap the original exception into a IOException. It seems the file system usually does this for all kind of errors?

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 5, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Newer versions are required to make IRSA (IAM Role for Service Account)
work properly with S3. Since presto-hive now also directly depends on
aws-java-sdk-sts, we make sure to exclude it from presto-hive and use
our own version instead.

This fixes IRSA for s3-presto, though not yet s3-hadoop.

This closes apache#16592.
@Airblader Airblader force-pushed the FLINK-23635 branch 2 times, most recently from 71cc3de to d602787 Compare August 5, 2021 07:50
@Airblader Airblader changed the title [FLINK-23635][s3-fs-presto] Fix PrestoS3FileSystemITCase [FLINK-23487][FLINK-23635][s3] Update aws and presto-hive Aug 5, 2021
We previously expected and asserted on an IOException. However,
presto-hive now uses the AWSCredentialsProviderChain when building the
S3 client, and we instead fail with an SdkClientException.
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After an offline discussion with @AHeise we will let the SdkClientException propagate as IOException is more intended for retryability which is not the case for config issues.

@twalthr twalthr closed this in e8325cc Aug 6, 2021
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
Newer versions are required to make IRSA (IAM Role for Service Account)
work properly with S3. Since presto-hive now also directly depends on
aws-java-sdk-sts, we make sure to exclude it from presto-hive and use
our own version instead.

This fixes IRSA for s3-presto, though not yet s3-hadoop.

This closes apache#16717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants