Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VALUES #1050

Merged
merged 1 commit into from
Feb 27, 2014
Merged

Implement VALUES #1050

merged 1 commit into from
Feb 27, 2014

Conversation

dain
Copy link
Contributor

@dain dain commented Feb 16, 2014

No description provided.

@damiencarol
Copy link
Contributor

👍

@dain
Copy link
Contributor Author

dain commented Feb 16, 2014

We should be able to prune the columns for queries like:

SELECT count(*) FROM (VALUES (1.1, 2), (sin(3.3), 2+2)) x (a, b);
SELECT a FROM (VALUES (1.1, 2), (sin(3.3), 2+2)) x (a, b)

But I don't know where we would put that code. Also it would require special handling for no-columns.

@damiencarol
Copy link
Contributor

I don't know this syntax and we (at my company) only need simple implementation of VALUES.

SQL-92 say that :

VALUES
It is a Function
Specify a set of s to be constructed into a table.

Does this PR implements the "simple" way ?

@martint
Copy link
Contributor

martint commented Feb 19, 2014

We should be able to prune the columns for queries like [...]
But I don't know where we would put that code. Also it would require special handling for no-columns.

You need to add a rule in PruneUnreferencedOutputs for ValuesNode. It needs to look at the list of expected outputs that gets passed in and drop anything the node produces that is not in that list.

@martint
Copy link
Contributor

martint commented Feb 26, 2014

Other than those comments, looks good

@dain dain merged commit d37923a into prestodb:master Feb 27, 2014
@dain dain deleted the values branch February 27, 2014 03:28
BryanCutler pushed a commit to BryanCutler/presto that referenced this pull request Jun 4, 2024
…ssue

Fix build issue in LocalQueryRunner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants