-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnest array of row to multiple columns #10883
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
presto-main/src/main/java/com/facebook/presto/operator/ArrayOfRowsUnnester.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.operator; | ||
|
|
||
| import com.facebook.presto.spi.PageBuilder; | ||
| import com.facebook.presto.spi.block.Block; | ||
| import com.facebook.presto.spi.block.BlockBuilder; | ||
| import com.facebook.presto.spi.block.ColumnarRow; | ||
| import com.facebook.presto.spi.type.RowType; | ||
| import com.facebook.presto.spi.type.Type; | ||
| import com.google.common.collect.ImmutableList; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static com.google.common.base.Preconditions.checkArgument; | ||
| import static com.google.common.base.Preconditions.checkState; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class ArrayOfRowsUnnester | ||
| implements Unnester | ||
| { | ||
| private final List<Type> fieldTypes; | ||
| private ColumnarRow columnarRow; | ||
| private int position; | ||
| private int nonNullPosition; | ||
| private int positionCount; | ||
|
|
||
| public ArrayOfRowsUnnester(Type elementType) | ||
| { | ||
| requireNonNull(elementType, "elementType is null"); | ||
| checkArgument(elementType instanceof RowType, "elementType is not of RowType"); | ||
| this.fieldTypes = ImmutableList.copyOf(elementType.getTypeParameters()); | ||
| } | ||
|
|
||
| @Override | ||
| public int getChannelCount() | ||
| { | ||
| return fieldTypes.size(); | ||
| } | ||
|
|
||
| @Override | ||
| public void appendNext(PageBuilder pageBuilder, int outputChannelOffset) | ||
| { | ||
| checkState(columnarRow != null, "columnarRow is null"); | ||
|
|
||
| for (int i = 0; i < fieldTypes.size(); i++) { | ||
| BlockBuilder blockBuilder = pageBuilder.getBlockBuilder(outputChannelOffset + i); | ||
| if (columnarRow.isNull(position)) { | ||
| blockBuilder.appendNull(); | ||
| } | ||
| else { | ||
| fieldTypes.get(i).appendTo(columnarRow.getField(i), nonNullPosition, blockBuilder); | ||
| } | ||
| } | ||
| if (!columnarRow.isNull(position)) { | ||
| nonNullPosition++; | ||
| } | ||
| position++; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasNext() | ||
| { | ||
| return position < positionCount; | ||
| } | ||
|
|
||
| @Override | ||
| public void setBlock(Block block) | ||
| { | ||
| this.position = 0; | ||
| this.nonNullPosition = 0; | ||
| if (block == null) { | ||
| this.columnarRow = null; | ||
| this.positionCount = 0; | ||
| } | ||
| else { | ||
| this.columnarRow = ColumnarRow.toColumnarRow(block); | ||
| this.positionCount = block.getPositionCount(); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 663 - 680 is same as line 562 - 580. And they are both doing unnest.
Would it make sense to refactor them? @martint @kokosing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite like how unnest is done through out the code base. the
is everywhere. If I were to do a refactoring, I'd prefer something doesn't require that. But I didn't see an easy way to do so. Would be more than happy to take suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extract the outer if as a static method.
I'm not sure what part of the following snippet you don't like
You could have done
switch(type.getTypeSignature().getBase(). But that makes little difference.