Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the description of hive.recursive-directories #12218

Closed
wants to merge 6 commits into from

Conversation

Sugaryou
Copy link

Add the description of hive.recursive-directories for hive connector so that others needn't look for the solution about how to make presto enable reading data from subdirectories in issues. I have seen many users asking about this question.

Add the description of hive.recursive-directories for hive connector so that others needn't look for the solution about how to make presto enable reading data from subdirectories in issues. I have seen many users asking about this question.
@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this documentation. I had a couple of minor comments. Please squash the commits when pushing an update (rather than adding new commits).

presto-docs/src/main/sphinx/connector/hive.rst Outdated Show resolved Hide resolved
@Sugaryou
Copy link
Author

Sugaryou commented Feb 3, 2019

May I ask if this commit could be ready to merge? Or is there anything wrong? @electrum

@rongrong
Copy link
Contributor

rongrong commented Feb 4, 2019

Please squash all commits into one. Thanks!

electrum pushed a commit to electrum/trino that referenced this pull request Feb 4, 2019
electrum pushed a commit to trinodb/trino that referenced this pull request Feb 4, 2019
@electrum
Copy link
Contributor

electrum commented Feb 4, 2019

I merged this in trinodb/trino#156

@Sugaryou
Copy link
Author

Nice. Is prestosql/presto another branch of presto?

@Sugaryou Sugaryou closed this Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants