Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve quotedness for Identifier when formatting Query #12223

Closed
wants to merge 0 commits into from

Conversation

Praveen2112
Copy link
Contributor

Currently Presto doesn't maintain the quotedness of an identifier when using SqlQueryFormatter so it results in throwing parsing error when we run prepare query of the syntax (#10739). This PR solves that above issue

@Praveen2112
Copy link
Contributor Author

Praveen2112 commented Jan 15, 2019

@findepi , @kokosing, @sopel39 Can you please review them ?

@martint
Copy link
Contributor

martint commented Jan 15, 2019

Thanks for submitting this PR, Praveen. The proper fix is more involved, though. We need to either make QualifiedName be composed of Identifiers, which already encode whether they are delimited, or preferably, get rid of QualifiedName altogether in favor of a combination of DerecerenceExpression and Identifier.

It’s a change I meant to do when I added support for delimited identifiers, but left it for later due to how much it touches and potential conflicts with other planner refactorings I’m working on.

@linux-foundation-easycla
Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants