New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bypass http call if the node is local #13838
Conversation
If a global config is set and the node-uri matches the current node, then use the task manager directly for fetching exchange data and doing task calls. That is bypass the taskResource if these conditions are satisfied. In addition, the backoff changed such that the local mode never undergoes a backoff. It's a bit hacky but does the job. Can be enabled (default is disabled) by setting task.bypass-http-for-local=true
@dharakk, I just briefly skimmed through the PR and here are some high-level comments:
|
Thanks @highker for the review. Having an abstraction is definitely the cleaner approach. I will rebase on top of #13894 and update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, let's rebase this on top of #13894 with proper abstraction.
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
#13937
If a global config is set and the node-uri matches the current
node, then use the task manager directly for fetching exchange data and
doing task calls. That is bypass the taskResource if these conditions
are satisfied.
In addition, the backoff changed such that the local mode
never undergoes a backoff. It's a bit hacky but does the job.
Can be enabled (default is disabled) by setting
task.bypass-http-for-local=true
In the low latency one-node setup (designed by @agrawaldevesh ), large sum of latency stemmed from http calls on the local host, this change helps shave of that latency piece