Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated grouped execution properties #15317

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove deprecated grouped execution properties #15317

merged 1 commit into from
Oct 16, 2020

Conversation

rschlussel
Copy link
Contributor

grouped_execution_for_aggregation and grouped_execution_for_join have
been replaced by a single property grouped_execution

dynamic_schedule_for_grouped_execution is enabled by default and doesn't
need a replacement.

Test plan - unit tests

== RELEASE NOTES ==

General Changes
* Remove deprecated configuration properties ``grouped-execution-for-aggregation-enabled`` and ``grouped-execution-for-join-enabled`` and their corresponding session properties ``grouped_execution_for_aggregation`` and ``grouped_execution_for_join``.  These have been replaced by a single configuration property ``grouped-execution-enabled`` and session property ``grouped-execution``
* Remove deprecated configuration property ``dynamic-schedule-for-grouped-execution`` and session property ``dynamic_schedule_for_grouped_execution``.  No replacement is needed.

@rschlussel rschlussel requested a review from a team October 15, 2020 22:06
@rschlussel
Copy link
Contributor Author

fixes #14885

viczhang861
viczhang861 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@viczhang861 viczhang861 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add "depended by PR in presto-facebook" to make tests pass.

@rschlussel
Copy link
Contributor Author

depended by https://github.com/facebookexternal/presto-facebook/pull/1238

@rschlussel
Remove deprecated grouped execution properties
cf398d7 
grouped_execution_for_aggregation and grouped_execution_for_join have
been replaced by a single property grouped_execution.

dynamic_schedule_for_grouped_execution is enabled by default and doesn't
need a replacement.
@rschlussel rschlussel merged commit 4479fb8 into prestodb:master Oct 16, 2020
@caithagoras caithagoras mentioned this pull request Oct 19, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhimondr arhimondr arhimondr approved these changes

@viczhang861 viczhang861 viczhang861 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rschlussel @arhimondr @viczhang861