Allow for CTAS table creation to external tables when write and creates are enabled for unmanaged tables #16147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-creates-enabled are both set to true, external tables can be created and inserted into. This change allows for that to be done in one step using the CREATE TABLE AS syntax. Referred Trino prestodb#2669 and follow up fix prestodb#2669 & prestodb#3755 Co-authored-by: alexjo2144 <jo.alex2144@gmail.com>
|
There is another commit missing trinodb/trino@883e38d |
aweisberg
suggested changes
Jan 7, 2022
| && !isS3FileSystem(context, hdfsEnvironment, path); | ||
| && !isS3FileSystem(context, hdfsEnvironment, path) | ||
| // Skip using temporary directory if destination is external. Target may be on a different file system. | ||
| && !externalLocation.isPresent(); |
There was a problem hiding this comment.
This was tweaked to be externalLocation.isEmpty() in Trino.
aweisberg
suggested changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-creates-enabled
are both set to true, external tables can be created and inserted into. This change
allows for that to be done in one step using the CREATE TABLE AS syntax.
Referred Trino #2669 and follow up fix #2669 & #3755
Co-authored-by: alexjo2144 jo.alex2144@gmail.com
Test plan - (Please fill in how you tested your changes)
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines. Don't forget to follow our attribution guidelines for any code copied from other projects.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.
If release note is NOT required, use: