Skip loading StaticCatalogStore and AccessControlManager for RM #16299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skip loading StatigCatalogStore and AccessControlManager for resource manager - Adding resource manager support in /v1/info endpoint
tdcmeehan
approved these changes
Jun 21, 2021
| @@ -69,7 +71,7 @@ public ServerInfoResource(NodeVersion nodeVersion, NodeInfo nodeInfo, ServerConf | |||
| @Produces(APPLICATION_JSON) | |||
| public ServerInfo getInfo() | |||
| { | |||
| boolean starting = !catalogStore.areCatalogsLoaded(); | |||
| boolean starting = resourceManager ? true : !catalogStore.areCatalogsLoaded(); | |||
There was a problem hiding this comment.
Suggested change
| boolean starting = resourceManager ? true : !catalogStore.areCatalogsLoaded(); | |
| boolean starting = resourceManager || !catalogStore.areCatalogsLoaded(); |
There was a problem hiding this comment.
By the way, why have this be true for RM? Should it not be false?
There was a problem hiding this comment.
Not sure how the flag is been used, but if the server is up thought this has to be true. Do you have more context on and if we should keep this flag false or true for RM?
There was a problem hiding this comment.
I think starting indicates some sort of initialization is occurring. There's no concept of that in RM right now, so my sense is it should always be false until that concept is developed and fully expressed in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan - On Test Cluster