[native] Fix the intermediate type of approx_percentile #18386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D39733152 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 22, 2022
Summary: X-link: prestodb/presto#18386 Pull Request resolved: facebookincubator#2621 Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix facebookincubator#2430 Differential Revision: D39733152 fbshipit-source-id: 6256b33f2ac3e6da405f0e0a0b14bfb85c17c8b0
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 27, 2022
Summary: X-link: prestodb/presto#18386 Pull Request resolved: facebookincubator#2621 Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix facebookincubator#2430 Differential Revision: D39733152 fbshipit-source-id: 5fc2ce9bbcecff2881d5e275393cc4ee4eab55c9
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 27, 2022
Summary: X-link: prestodb/presto#18386 Pull Request resolved: facebookincubator#2621 Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix facebookincubator#2430 Differential Revision: D39733152 fbshipit-source-id: 80ea0a3a9799ee7a070cc542b6b91268be71ae01
Yuhta
force-pushed
the
export-D39733152
branch
from
d066563
to
1e91a24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39733152 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Sep 28, 2022
Summary: X-link: prestodb/presto#18386 Pull Request resolved: facebookincubator#2621 Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix facebookincubator#2430 Reviewed By: mbasmanova Differential Revision: D39733152 fbshipit-source-id: f7476a9a4a2e92d7fdc976f388a07692787cada8
|
This pull request was exported from Phabricator. Differential Revision: D39733152 |
Yuhta
force-pushed
the
export-D39733152
branch
from
1e91a24
to
1efc007
Compare
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Sep 28, 2022
Summary: X-link: prestodb/presto#18386 Pull Request resolved: #2621 Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix #2430 Reviewed By: mbasmanova Differential Revision: D39733152 fbshipit-source-id: b47e784aabd70ba4324f0208bee35d427b7a1dc1
|
@ChunxuTang Hi can you take a look? The test will pass once we advance the Velox version |
|
@mbasmanova Can you help stamp and merge this PR? |
|
@Yuhta Jimmy, there are test failures. Would you take a look? |
The test should pass if we sync up the Velox version (I ran it on devserver before I land the change internally). Should I advance the version in this PR to make it pass? |
|
Yes, let's advance Velox version and add an e2e test that runs intermediate aggregation using approx_percentile. Also, please, update the commit message to following the guidelines at https://cbea.ms/git-commit/ and wrap it at 72 characters. |
Yuhta
force-pushed
the
export-D39733152
branch
from
1efc007
to
8b0aca4
Compare
Yuhta
changed the title
ROW
Yuhta
force-pushed
the
export-D39733152
branch
from
8b0aca4
to
87ea8fd
Compare
Before this change, intermediate aggregation node for `approx_percentile` in worker only sees a type signature of `VARBINARY -> VARBINARY`, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is not `DOUBLE`. This fix changes the intermediate result type to `ROW` so that we can get the value type from it and instantiate accumulator with proper type. Fix facebookincubator/velox#2430
Yuhta
force-pushed
the
export-D39733152
branch
from
87ea8fd
to
e1585a4
Compare
|
@spershin @mbasmanova Some unrelated tests failed, can we still merge it? |
|
@majetideepak Deepak, I thought you fixed these failures. Would you take a look? |
|
@mbasmanova these failures are different. #18437 is tracking this. I am going to take a look. |
mbasmanova
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
@Yuhta Thank you, Jimmy. Accepting based on @majetideepak comment that suggests that test failures are unrelated and are being looked into separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before this change, intermediate aggregation node for
approx_percentilein worker only sees a type signature ofVARBINARY -> VARBINARY, thus not be able to figure out the actual value type and cannot perform the merge properly when the value type is notDOUBLE.This fix changes the intermediate result type to
ROWso that we can get the value type from it and instantiate accumulator with proper type.Fix facebookincubator/velox#2430
Differential Revision: D39733152