Fix ROUND() returning incorrect results for edge cases #18451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROUND(double, integer)
andROUND(real, integer)
are returning wrong results for edge cases:ROUND(double'1e100', 0)
returns 9223372036854800000Math.round(num*factor)
overflow: currentlyROUND(double'1', 20)
returns 0.092233720368548Instead, we use this approach by scaling down a BigDecimal.
Test plan -
mvn -Dtest="TestMathFunctions" test