DiscoveryNodeManager to not return Coordinator/Resource Manager if not allowed by NodeStatusService #18473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t allowed by NodeStatusService In some mysterious conditions, we noticed coordinators are showing up in discovery service, and this lead to a bad state where resource managed start failing getResourceGroupInfo call due to incosistency in the coordinator count. we won't to mitigate it by removing this checks which are no longer needed given NodeStatusService should filter them.
arunthirupathi
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some mysterious conditions, we noticed coordinators are showing up in discovery service, and this lead to a bad state where resource managed start failing getResourceGroupInfo call due to incosistency in the coordinator count. we want to mitigate it by removing this checks which are no longer needed given NodeStatusService should filter them.
Redoes the old PR #18086 which got reverted: #18193 due to an issue of active coordinators were not found during verifier run.
Test plan - Verifier run