(Not ready for review) Use builder pattern for ParquetReader #18633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxinli
force-pushed
the
xinli_refactor
branch
2 times, most recently
from
f67c7f8
to
2b45343
Compare
shangxinli
changed the title
shangxinli
changed the title
shangxinli
force-pushed
the
xinli_refactor
branch
3 times, most recently
from
67fea02
to
cad0325
Compare
shangxinli
force-pushed
the
xinli_refactor
branch
from
cad0325
to
0d5c126
Compare
shangxinli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParquetReader() method has a long list of parameters. It is cumbersome to use it as it needs to remember the parameters and orders. This is a perfect candidate to use Java builder to make it easier.